add replace_char() method to SkString API (skbug.com/2651)

include/core/SkString.h

Index: include/core/SkString.h
diff --git a/include/core/SkString.h b/include/core/SkString.h
index bc06cb0aba63743e90f6869f6f042c98011b1267..f3fb4df36d44cf4ff87119a68be17e25a0c221d4 100644
--- a/include/core/SkString.h
+++ b/include/core/SkString.h
@@ -191,6 +191,8 @@ public:
     void prependHex(uint32_t value, int minDigits = 0) { this->insertHex(0, value, minDigits); }
     void prependScalar(SkScalar value) { this->insertScalar((size_t)-1, value); }
 
+    void replaceChar(char oldChar, char newChar);

[reed1, 2014/08/13 19:13:36]

ick -- are we logically trying to replace a byte, or a "character". If the
latter, then pass SkUnichar. If the former... really?

+
     void printf(const char format[], ...) SK_PRINTF_LIKE(2, 3);
     void appendf(const char format[], ...) SK_PRINTF_LIKE(2, 3);
     void appendVAList(const char format[], va_list);