add replace_char() method to SkString API (skbug.com/2651)

include/core/SkString.h

Index: include/core/SkString.h
diff --git a/include/core/SkString.h b/include/core/SkString.h
index bc06cb0aba63743e90f6869f6f042c98011b1267..e1d2c3590ad6a5f17de07483091b5c10af1fbd4e 100644
--- a/include/core/SkString.h
+++ b/include/core/SkString.h
@@ -191,6 +191,9 @@ public:
     void prependHex(uint32_t value, int minDigits = 0) { this->insertHex(0, value, minDigits); }
     void prependScalar(SkScalar value) { this->insertScalar((size_t)-1, value); }
 
+    /* Replace all occurrences of oldChar with newChar */

[reed1, 2014/06/11 13:40:50]

Please document what happens
- if oldChar or newChar is 0
- if we allow oldChar or newChar to be 8-bit (i.e. part of a compound utf8
sequence

+    void replaceChar(const char oldChar, const char newChar);

[reed1, 2014/06/11 13:40:50]

we don't say 'const' for non-ptr/ref parameters

+
     void printf(const char format[], ...) SK_PRINTF_LIKE(2, 3);
     void appendf(const char format[], ...) SK_PRINTF_LIKE(2, 3);
     void appendVAList(const char format[], va_list);