add replace_char() method to SkString API (skbug.com/2651)

include/core/SkString.h

Index: include/core/SkString.h
diff --git a/include/core/SkString.h b/include/core/SkString.h
index bc06cb0aba63743e90f6869f6f042c98011b1267..437c2ccd14e69fcc16175232f18a413d11495fc2 100644
--- a/include/core/SkString.h
+++ b/include/core/SkString.h
@@ -191,6 +191,9 @@ public:
     void prependHex(uint32_t value, int minDigits = 0) { this->insertHex(0, value, minDigits); }
     void prependScalar(SkScalar value) { this->insertScalar((size_t)-1, value); }
 

[epoger, 2014/06/11 11:01:33]

Please add unittests in
https://skia.googlesource.com/skia/+/master/tests/StringTest.cpp

[rs.prinja, 2014/06/11 12:08:03]

Done.

+    /* Replace all occurrences of oldChar with newChar */
+    void replace_char(const char oldChar, const char newChar);

[epoger, 2014/06/11 11:01:33]

For consistency, please call this either replace() or replaceChar().  I'm not
sure which is better.

[rs.prinja, 2014/06/11 12:08:03]

I'm calling it replaceChar for the time being. Will reupload if replace() or
some other name sounds better to everyone.

+
     void printf(const char format[], ...) SK_PRINTF_LIKE(2, 3);
     void appendf(const char format[], ...) SK_PRINTF_LIKE(2, 3);
     void appendVAList(const char format[], va_list);