add replace_char() method to SkString API (skbug.com/2651)

tests/StringTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <stdarg.h>
 #include <stdio.h>
 #include "SkString.h"
@@ skipping 130 matching lines @@
     a.set("");
     a.appendU64(0x8000000000000001ULL, 0);
     REPORTER_ASSERT(reporter, a.equals("9223372036854775809"));
     a.set("");
     a.appendU64(0xFFFFFFFFFFFFFFFFULL, 0);
     REPORTER_ASSERT(reporter, a.equals("18446744073709551615"));
     a.set("");
     a.appendU64(0x0000000001000000ULL, 15);
     REPORTER_ASSERT(reporter, a.equals("000000016777216"));
 
+    a.set("hello world");

[tfarina, 2014/06/13 17:02:10]

If Elliot and Mike don't mind, could you set up a separate test for this? e.g.:

DEF_TEST(String_ReplaceChar, r) {
  ...
}

+    a.replaceChar('h', 'h');
+    REPORTER_ASSERT(reporter, a.equals("hello world"));
+    a.replaceChar('x', 'x');
+    REPORTER_ASSERT(reporter, a.equals("hello world"));
+    a.replaceChar('o', 'e');
+    REPORTER_ASSERT(reporter, a.equals("helle werld"));
+    a.replaceChar('x', 'e');
+    REPORTER_ASSERT(reporter, a.equals("helle werld"));
+    a.replaceChar('x', 'z');
+    REPORTER_ASSERT(reporter, a.equals("helle werld"));
+    a.set("");
+    a.replaceChar('a', 'b');
+    REPORTER_ASSERT(reporter, a.equals(""));
+
     static const struct {
         SkScalar    fValue;
         const char* fString;
     } gRec[] = {
         { 0,            "0" },
         { SK_Scalar1,   "1" },
         { -SK_Scalar1,  "-1" },
         { SK_Scalar1/2, "0.5" },
   #ifdef SK_BUILD_FOR_WIN
         { 3.4028234e38f,   "3.4028235e+038" },
@@ skipping 30 matching lines @@
 
     SkStrSplit("a-_b_c-dee--f-_-_-g-", "-_", &results);
     REPORTER_ASSERT(r, results.count() == 6);
     REPORTER_ASSERT(r, results[0].equals("a"));
     REPORTER_ASSERT(r, results[1].equals("b"));
     REPORTER_ASSERT(r, results[2].equals("c"));
     REPORTER_ASSERT(r, results[3].equals("dee"));
     REPORTER_ASSERT(r, results[4].equals("f"));
     REPORTER_ASSERT(r, results[5].equals("g"));
 }