Issue 322253004: Change compositing/gestures tests to avoid a one pixel difference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322253004: Change compositing/gestures tests to avoid a one pixel difference (Closed)

Created:
6 years, 6 months ago by eae

Modified:
6 years, 6 months ago

Reviewers:
dglazkov

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Change compositing/gestures tests to avoid a one pixel difference Change the compositing/gestures tests to avoid a problem where one pixel is one shade of green lighter due to the underline bleeding through the rounded corners of the rect. Also change position/size calculation to use getBoundingClientRect which is faster and more reliable. BUG=378610 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175961

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -36 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+1 line, -15 lines	0 comments	Download
M	LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text-2.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/compositing/gestures/resources/link-highlight-helper.js	View		1 chunk	+4 lines, -21 lines	0 comments	Download
M	LayoutTests/compositing/gestures/resources/link-highlight-style.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/322253004/20001

6 years, 6 months ago (2014-06-11 15:31:12 UTC) #4

Message was sent while issue was closed.

Change committed as 175961

Expand Messages | Collapse Messages