Issue 322253002: Allow "freezing" NativePages to spare up memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322253002: Allow "freezing" NativePages to spare up memory. (Closed)

Created:
6 years, 6 months ago by newt (away)

Modified:
6 years, 6 months ago

Reviewers:
Ted C

CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow "freezing" NativePages to spare up memory. If the user opens many tabs and navigates to a NativePage in each tab, the NativePages may use enough memory to cause a Java out-of-memory error. This adds a method Tab.freezeNativePage() which destroys the current native page and replaces it with a FrozenNativePage, which allows querying getTitle(), getUrl(), etc, but can't be displayed. BUG=359573 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276342

Patch Set 1 #

Patch Set 2 : removed assert false from updateForUrl() #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -0 lines)			Patch
	A	chrome/android/java/src/org/chromium/chrome/browser/FrozenNativePage.java	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/Tab.java	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/322253002/20001

6 years, 6 months ago (2014-06-11 00:14:43 UTC) #4

Message was sent while issue was closed.

Change committed as 276342

Expand Messages | Collapse Messages