Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 322233003: Remove an unnecessary SkBitmap copy on BitmapFetcher::OnImageDecoded. (Closed)

Created:
6 years, 6 months ago by Kibeom Kim (inactive)
Modified:
6 years, 6 months ago
Reviewers:
groby-ooo-7-16, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove an unnecessary SkBitmap copy on BitmapFetcher::OnImageDecoded. BitmapFetcher was doing a deep copy on UI thread. It took ~100ms for a large image (5400x2700) on Nexus 4. BUG=374029, 380801 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/bitmap_fetcher.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Kibeom Kim (inactive)
6 years, 6 months ago (2014-06-10 22:45:08 UTC) #1
groby-ooo-7-16
LGTM.
6 years, 6 months ago (2014-06-10 22:52:08 UTC) #2
sky
LGTM
6 years, 6 months ago (2014-06-11 15:41:45 UTC) #3
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 6 months ago (2014-06-11 17:14:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/322233003/1
6 years, 6 months ago (2014-06-11 17:19:07 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:27:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:31:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19637)
6 years, 6 months ago (2014-06-11 21:31:17 UTC) #8
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 6 months ago (2014-06-11 22:12:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/322233003/1
6 years, 6 months ago (2014-06-11 22:14:05 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:18:04 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:20:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19749)
6 years, 6 months ago (2014-06-11 22:20:40 UTC) #13
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 6 months ago (2014-06-12 11:43:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/322233003/1
6 years, 6 months ago (2014-06-12 11:44:42 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:53:36 UTC) #16
Message was sent while issue was closed. 
Change committed as 276645

Powered by Google App Engine
This is Rietveld 408576698