Remove more unretained

Remove more unretained

BUG=349083
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277137

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277655

[oshima, 2014-06-10 21:28:05]

not all are unsafe, but since window manager supports weak ptr, let's use weak
pointer for all cases.

[oshima, 2014-06-13 14:42:05]

ping?

[bshe, 2014-06-13 15:00:39]

On 2014/06/13 14:42:05, oshima wrote:
> ping?

sorry for the delay. lgtm

[oshima, 2014-06-13 15:17:23]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-06-13 15:18:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/322233002/1

[commit-bot: I haz the power, 2014-06-13 17:56:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-13 19:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 19:11:42]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[oshima, 2014-06-13 22:40:37]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-06-13 22:44:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/322233002/1

[commit-bot: I haz the power, 2014-06-14 00:05:59]

Change committed as 277137

[please use gerrit instead, 2014-06-14 15:51:54]

A revert of this CL has been created in
https://codereview.chromium.org/331033002/ by rouslan@chromium.org.

The reason for reverting is: Appears to have broken
WallpaperManagerPolicyTest.PRE_PRE_WallpaperOnLoginScreen on
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

[30103:30164:0613/224522:FATAL:weak_ptr.cc(26)] Check failed:
sequence_checker_.CalledOnValidSequencedThread(). WeakPtrs must be checked on
the same sequenced thread.
#0 0x7f486887bd6d base::debug::StackTrace::StackTrace()
#1 0x7f48688f8581 logging::LogMessage::~LogMessage()
#2 0x7f4868914936 base::internal::WeakReference::Flag::IsValid()
#3 0x7f4868914a03 base::internal::WeakReference::is_valid()
#4 0x000002f40b7e base::WeakPtr\u003C>::get()
#5 0x000002f3e405 base::internal::InvokeHelper\u003C>::MakeItSo()
#6 0x000002f3a45f base::internal::Invoker\u003C>::Run()
#7 0x7f486886685b base::Callback\u003C>::Run()
#8 0x7f48689bf4fd base::SequencedWorkerPool::Inner::ThreadLoop()
#9 0x7f48689bdd83 base::SequencedWorkerPool::Worker::Run()
#10 0x7f48689c9704 base::SimpleThread::ThreadMain()
#11 0x7f48689bc575 base::(anonymous namespace)::ThreadFunc()
#12 0x7f48647dde9a start_thread
#13 0x7f4861d733fd clone.

[oshima, 2014-06-16 19:44:40]

On 2014/06/14 15:51:54, Rouslan Solomakhin wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/331033002/ by mailto:rouslan@chromium.org.
> 
> The reason for reverting is: Appears to have broken
> WallpaperManagerPolicyTest.PRE_PRE_WallpaperOnLoginScreen on
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
> 
> [30103:30164:0613/224522:FATAL:weak_ptr.cc(26)] Check failed:
> sequence_checker_.CalledOnValidSequencedThread(). WeakPtrs must be checked on
> the same sequenced thread.
> #0 0x7f486887bd6d base::debug::StackTrace::StackTrace()
> #1 0x7f48688f8581 logging::LogMessage::~LogMessage()
> #2 0x7f4868914936 base::internal::WeakReference::Flag::IsValid()
> #3 0x7f4868914a03 base::internal::WeakReference::is_valid()
> #4 0x000002f40b7e base::WeakPtr\u003C>::get()
> #5 0x000002f3e405 base::internal::InvokeHelper\u003C>::MakeItSo()
> #6 0x000002f3a45f base::internal::Invoker\u003C>::Run()
> #7 0x7f486886685b base::Callback\u003C>::Run()
> #8 0x7f48689bf4fd base::SequencedWorkerPool::Inner::ThreadLoop()
> #9 0x7f48689bdd83 base::SequencedWorkerPool::Worker::Run()
> #10 0x7f48689c9704 base::SimpleThread::ThreadMain()
> #11 0x7f48689bc575 base::(anonymous namespace)::ThreadFunc()
> #12 0x7f48647dde9a start_thread
> #13 0x7f4861d733fd clone.

thanks for taking care of it.

bshe@, I makde WallpaperManager::SaveCustomWallpaper static as it doesn't have
to be an instance method.
patch set 2 has a diff from the original CL , and patch set 3 simply moved the
static methods. PTAL.

[bshe, 2014-06-16 20:37:16]

On 2014/06/16 19:44:40, oshima wrote:
> On 2014/06/14 15:51:54, Rouslan Solomakhin wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/331033002/ by mailto:rouslan@chromium.org.
> > 
> > The reason for reverting is: Appears to have broken
> > WallpaperManagerPolicyTest.PRE_PRE_WallpaperOnLoginScreen on
> >
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
> > 
> > [30103:30164:0613/224522:FATAL:weak_ptr.cc(26)] Check failed:
> > sequence_checker_.CalledOnValidSequencedThread(). WeakPtrs must be checked
on
> > the same sequenced thread.
> > #0 0x7f486887bd6d base::debug::StackTrace::StackTrace()
> > #1 0x7f48688f8581 logging::LogMessage::~LogMessage()
> > #2 0x7f4868914936 base::internal::WeakReference::Flag::IsValid()
> > #3 0x7f4868914a03 base::internal::WeakReference::is_valid()
> > #4 0x000002f40b7e base::WeakPtr\u003C>::get()
> > #5 0x000002f3e405 base::internal::InvokeHelper\u003C>::MakeItSo()
> > #6 0x000002f3a45f base::internal::Invoker\u003C>::Run()
> > #7 0x7f486886685b base::Callback\u003C>::Run()
> > #8 0x7f48689bf4fd base::SequencedWorkerPool::Inner::ThreadLoop()
> > #9 0x7f48689bdd83 base::SequencedWorkerPool::Worker::Run()
> > #10 0x7f48689c9704 base::SimpleThread::ThreadMain()
> > #11 0x7f48689bc575 base::(anonymous namespace)::ThreadFunc()
> > #12 0x7f48647dde9a start_thread
> > #13 0x7f4861d733fd clone.
> 
> thanks for taking care of it.
> 
> bshe@, I makde WallpaperManager::SaveCustomWallpaper static as it doesn't have
> to be an instance method.
> patch set 2 has a diff from the original CL , and patch set 3 simply moved the
> static methods. PTAL.

lgtm

[oshima, 2014-06-16 21:02:58]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-06-16 21:06:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/322233002/80001

[commit-bot: I haz the power, 2014-06-17 03:42:49]

Change committed as 277655