Issue 322203004: Speed up IDB by trimming down the BlobChangeMaps. Check to see if we need each

Issue 322203004: Speed up IDB by trimming down the BlobChangeMaps. Check to see if we need each (Closed)

Created:
6 years, 6 months ago by ericu

Modified:
6 years, 6 months ago

Reviewers:
jsbell, cmumford

CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Speed up IDB by trimming down the BlobChangeMaps. Check to see if we need each entry before adding it. BUG=380798 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276331

Patch Set 2 : Change Iterator to a Get #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -6 lines)			Patch
	M	content/browser/indexed_db/indexed_db_backing_store.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	content/browser/indexed_db/indexed_db_backing_store.cc	View	1	3 chunks	+41 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

jsbell

https://codereview.chromium.org/322203004/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/322203004/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc#newcode4169 content/browser/indexed_db/indexed_db_backing_store.cc:4169: scoped_ptr<LevelDBIterator> it = transaction()->CreateIterator(); Why an iterator instead of ...

6 years, 6 months ago (2014-06-10 22:16:33 UTC) #2

ericu

6 years, 6 months ago (2014-06-10 22:30:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/322203004/20001

6 years, 6 months ago (2014-06-10 23:33:07 UTC) #7

Message was sent while issue was closed.

Change committed as 276331

Expand Messages | Collapse Messages