Issue 322173002: Printing: Minor cleanup and tweaks in PrintWebViewHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322173002: Printing: Minor cleanup and tweaks in PrintWebViewHelper. (Closed)

Created:
6 years, 6 months ago by Lei Zhang

Modified:
6 years, 6 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Printing: Minor cleanup and tweaks in PrintWebViewHelper. - No need to use scoped_ptr.get() in conditionals. - Check return value from SharedMemory::GiveToProcess(). - Remove a NOTREACHED(), as memory sharing can fail. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276404

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	chrome/renderer/printing/print_web_view_helper.cc	View		5 chunks	+8 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/322173002/1

6 years, 6 months ago (2014-06-10 20:10:19 UTC) #3

Message was sent while issue was closed.

Change committed as 276404

Expand Messages | Collapse Messages