Move HistoryService::NotifyProfileError to HistoryClient

Move HistoryService::NotifyProfileError to HistoryClient

BUG=380143
R=sdefresne
TBR=shess (add sql to DEPS)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276549

[方觉(Fang Jue), 2014-06-10 15:37:02]

I got a presubmit warning while uploading this patch:

You added one or more #includes of files that are temporarily
allowed but being removed. Can you avoid introducing the
#include? See relevant DEPS file(s) for details and contacts.
  chrome/browser/history/chrome_history_client.cc
      Illegal include: "chrome/browser/ui/profile_error_dialog.h"
    Because of "!chrome/browser/ui/profile_error_dialog.h" from
chrome/browser/history's include_rules.

But actually it's just moved from history_service to chrome_history_client. What
should I do with it?

[sdefresne, 2014-06-10 15:54:36]

LGTM

You can ignore that warning. It is fine moving #include from file that will be
moved into the component (history_service.cc) to file that won't
(chrome_history_client.cc).

Please mark the bug as Started and assign it to yourself to prevent duplication
of effort.

+blundell for OWNERS

[方觉(Fang Jue), 2014-06-10 15:57:25]

On 2014/06/10 15:54:36, sdefresne wrote:
> LGTM
> 
> You can ignore that warning. It is fine moving #include from file that will be
> moved into the component (history_service.cc) to file that won't
> (chrome_history_client.cc).
> 
CQ will refuse to commit if there are presubmit warnings IIRC.

> Please mark the bug as Started and assign it to yourself to prevent
duplication
> of effort.
> 
I don't have permission to edit bugs.

[sdefresne, 2014-06-10 16:04:42]

On 2014/06/10 15:57:25, 方觉(Fang Jue) wrote:
> On 2014/06/10 15:54:36, sdefresne wrote:
> > LGTM
> > 
> > You can ignore that warning. It is fine moving #include from file that will
be
> > moved into the component (history_service.cc) to file that won't
> > (chrome_history_client.cc).
> > 
> CQ will refuse to commit if there are presubmit warnings IIRC.

I was able to commit through CQ other CLs with the same warnings, so it should
work. If not, I'll manually land it for you.

> > Please mark the bug as Started and assign it to yourself to prevent
> duplication
> > of effort.
> > 
> I don't have permission to edit bugs.

OK. I've marked the bugs as Started an put you in cc.
Thank you for your help.

[blundell, 2014-06-11 12:21:57]

LGTM

https://codereview.chromium.org/322113002/diff/1/components/history/core/brow...
File components/history/core/browser/history_client.h (right):

https://codereview.chromium.org/322113002/diff/1/components/history/core/brow...
components/history/core/browser/history_client.h:47: // Show the error dialog
when there is problem reading the database.
"Notifies the embedder that there was a problem reading the database."

[方觉(Fang Jue), 2014-06-11 12:33:48]

https://codereview.chromium.org/322113002/diff/1/components/history/core/brow...
File components/history/core/browser/history_client.h (right):

https://codereview.chromium.org/322113002/diff/1/components/history/core/brow...
components/history/core/browser/history_client.h:47: // Show the error dialog
when there is problem reading the database.
On 2014/06/11 12:21:57, blundell wrote:
> "Notifies the embedder that there was a problem reading the database."

Done.

[方觉(Fang Jue), 2014-06-11 12:47:32]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-11 12:48:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322113002/20001

[方觉(Fang Jue), 2014-06-11 12:57:23]

The CQ bit was unchecked by fangjue23303@gmail.com

[方觉(Fang Jue), 2014-06-11 13:02:37]

** Presubmit ERRORS **
Missing LGTM from OWNERS of dependencies added to DEPS:
    '+sql',

Looks like I should add someone from sql/OWNERS to review this?

[blundell, 2014-06-11 13:03:46]

On 2014/06/11 13:02:37, 方觉(Fang Jue) wrote:
> ** Presubmit ERRORS **
> Missing LGTM from OWNERS of dependencies added to DEPS:
>     '+sql',
> 
> Looks like I should add someone from sql/OWNERS to review this?

You can TBR shess@ on that.

[方觉(Fang Jue), 2014-06-11 13:21:26]

TBR shess for adding sql to DEPS.

[方觉(Fang Jue), 2014-06-11 15:18:09]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-11 15:22:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322113002/20001

[commit-bot: I haz the power, 2014-06-11 20:59:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[Scott Hess - ex-Googler, 2014-06-11 21:30:54]

lgtm

[commit-bot: I haz the power, 2014-06-11 21:38:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:38:52]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[方觉(Fang Jue), 2014-06-12 01:59:43]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-12 02:02:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322113002/20001

[commit-bot: I haz the power, 2014-06-12 02:19:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-12 02:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 02:23:27]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[方觉(Fang Jue), 2014-06-12 02:45:16]

The CQ bit was checked by fangjue23303@gmail.com

[commit-bot: I haz the power, 2014-06-12 02:48:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/322113002/20001

[commit-bot: I haz the power, 2014-06-12 06:27:58]

Change committed as 276549