Evaluate MediaQueryLists on actual media changes only.

Evaluate MediaQueryLists on actual media changes only.

MediaQueryLists were re-evaluated for every styleResolverChanged(). The
evaluation of MediaQueryLists can only change when some media type or
features change. That is signalled through mediaQueryAffectingValueChanged().
Set m_evaluateMediaQueriesOnStyleRecalc there instead.

Since the media queries don't change this is not noticable through layout
or unit testing.

R=esprehn@chromium.org
BUG=382894
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176406

[rune, 2014-06-12 13:15:02]

PTAL

[esprehn, 2014-06-18 06:16:02]

lgtm

[commit-bot: I haz the power, 2014-06-18 06:16:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/322043008/1

[commit-bot: I haz the power, 2014-06-18 06:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 06:17:15]

Failed to apply patch for Source/core/dom/Document.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.cpp
  Hunk #1 succeeded at 680 (offset 5 lines).
  Hunk #2 FAILED at 3456.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/dom/Document.cpp.rej

Patch:       Source/core/dom/Document.cpp
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index
b02ebb32ff5c130637a9a4f15feec854a4a9d5dd..0ad81d7156e34c58781f780aece8c240e2d5fbe3
100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -675,6 +675,7 @@ MediaQueryMatcher& Document::mediaQueryMatcher()
 
 void Document::mediaQueryAffectingValueChanged()
 {
+    m_evaluateMediaQueriesOnStyleRecalc = true;
     styleEngine()->clearMediaQueryRuleSetStyleSheets();
 }
 
@@ -3455,7 +3456,6 @@ void
Document::styleResolverChanged(StyleResolverUpdateMode updateMode)
     if (!change.needsStyleRecalc())
         return;
 
-    m_evaluateMediaQueriesOnStyleRecalc = true;
     setNeedsStyleRecalc(SubtreeStyleChange);
 }

[rune, 2014-06-18 07:41:41]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-06-18 07:42:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/322043008/20001

[commit-bot: I haz the power, 2014-06-18 09:48:41]

Change committed as 176406