Issue 32203002: Fix crash https://code.google.com/p/dart/issues/detail?id=14014: remove what seems to be obsolete c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 32203002: Fix crash https://code.google.com/p/dart/issues/detail?id=14014: remove what seems to be obsolete c… (Closed)

Created:
7 years, 2 months ago by ngeoffray

Modified:
7 years, 2 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash https://code.google.com/p/dart/issues/detail?id=14014: remove what seems to be obsolete code. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=28985

Patch Set 2 : #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -12 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View	1	1 chunk	+6 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1	1 chunk	+13 lines, -0 lines	1 comment	Download
A	tests/language/function_type2_test.dart	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A	tests/language/issue14014_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Thanks Johnni. PTAL, I have updated the code to fix the issue you raised in ...

7 years, 2 months ago (2013-10-21 13:26:51 UTC) #3

Johnni Winther

lgtm https://codereview.chromium.org/32203002/diff/30001/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/32203002/diff/30001/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode672 sdk/lib/_internal/compiler/implementation/dart_types.dart:672: void forEachTypeVariable(f(TypeVariableType variable)) { Good catch!

7 years, 2 months ago (2013-10-21 15:13:48 UTC) #4

ngeoffray

7 years, 2 months ago (2013-10-22 06:39:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r28985 (presubmit successful).

Expand Messages | Collapse Messages

Issue 32203002: Fix crash https://code.google.com/p/dart/issues/detail?id=14014: remove what seems to be obsolete c… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages