Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 322003004: ServiceWorker: Fill waiting version if stored data is not active (Closed)

Created:
6 years, 6 months ago by nhiroki
Modified:
6 years, 6 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Fill waiting version if stored data is not active BUG=380030 TEST=n/a Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/browser/service_worker/service_worker_storage.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nhiroki
Anyone can review this? Thanks!
6 years, 6 months ago (2014-06-10 01:06:22 UTC) #1
nhiroki
michaeln@, can you take a look at this?
6 years, 6 months ago (2014-06-11 11:05:24 UTC) #2
michaeln
lgtm
6 years, 6 months ago (2014-06-11 16:41:13 UTC) #3
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 6 months ago (2014-06-11 23:19:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/322003004/1
6 years, 6 months ago (2014-06-11 23:21:07 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:41:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:43:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160490) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149897) mac_chromium_compile_dbg ...
6 years, 6 months ago (2014-06-12 00:43:03 UTC) #8
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 6 months ago (2014-06-12 02:15:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/322003004/1
6 years, 6 months ago (2014-06-12 02:19:39 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 09:37:51 UTC) #11
Message was sent while issue was closed.
Change committed as 276605

Powered by Google App Engine
This is Rietveld 408576698