aura-linux: Supports deadkey + shift + alphabet for XIM.

aura-linux: Supports deadkey + shift + alphabet for XIM.

https://codereview.chromium.org/243143002/ was incomplete and it does not take care of deadkey + shift + alphabet combinations.  This CL complements it and takes care of key sequences including shift key.

BUG=367103
TEST=Done manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277714

[Yuki, 2014-06-10 15:04:23]

Could you review this CL?

[sadrul, 2014-06-12 10:49:33]

This change LGTM. But can we have test-coverage for the IME related code in
here?

https://codereview.chromium.org/321963003/diff/1/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/321963003/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:164: // state=0 for the composition, and the sequence of
X11 key events will be
Should you update this comment too?

[Yuki, 2014-06-12 13:13:24]

Added a unittest.
Could you take another look?

https://codereview.chromium.org/321963003/diff/1/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/321963003/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:164: // state=0 for the composition, and the sequence of
X11 key events will be
On 2014/06/12 10:49:32, sadrul wrote:
> Should you update this comment too?

Done.

[Yuki, 2014-06-17 05:21:43]

On 2014/06/12 13:13:24, Yuki wrote:
> Added a unittest.
> Could you take another look?
> 
> https://codereview.chromium.org/321963003/diff/1/ui/events/x/events_x.cc
> File ui/events/x/events_x.cc (right):
> 
>
https://codereview.chromium.org/321963003/diff/1/ui/events/x/events_x.cc#newc...
> ui/events/x/events_x.cc:164: // state=0 for the composition, and the sequence
of
> X11 key events will be
> On 2014/06/12 10:49:32, sadrul wrote:
> > Should you update this comment too?
> 
> Done.

I'll commit this CL assuming that you're okay with the last change.
If you find any issues, please let me know.

[Yuki, 2014-06-17 05:21:48]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-06-17 05:23:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yukishiino@chromium.org/321963003/40001

[commit-bot: I haz the power, 2014-06-17 10:34:55]

Change committed as 277714