Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2674)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 321943005: Fix bug with range of shift operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | tests/language/vm/optimized_shl_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 37170)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -2655,7 +2655,7 @@
if (is_truncating) {
if (right_needs_check) {
const bool right_may_be_negative =
- (right_range == NULL) || right_range->IsNegative();
+ (right_range == NULL) || !right_range->IsPositive();
if (right_may_be_negative) {
ASSERT(shift_left->CanDeoptimize());
__ CompareImmediate(right, Immediate(0), PP);
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | tests/language/vm/optimized_shl_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698