Disable prerender on mobile for 1% users (retry).

Disable prerender on mobile for 1% users (retry).

r249463 was intended for this, but it turned out --prerender=enabled is
specified by default for Android and prerender is enabled for 100%
users.

BUG=341056
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276579

[Shuhei Takahashi, 2014-06-10 08:36:11]

tedchoc@chromium.org: Could you review this change?

[cbentzel, 2014-06-10 09:34:05]

Could Finch be used to control this instead?

[Shuhei Takahashi, 2014-06-10 13:47:14]

On 2014/06/10 09:34:05, cbentzel wrote:
> Could Finch be used to control this instead?

I agree it's better to switch to Finch rather than hard-coded configuration.
But that's another problem that should be addressed in separate CL, because even
if we switch to Finch, its configuration is not used due to hard-coded
--prerender=enabled flag.

[Ted C, 2014-06-10 16:35:58]

lgtm, pending cbentzel ack that this approach is ok.

[Shuhei Takahashi, 2014-06-11 08:21:55]

On 2014/06/10 16:35:58, Ted C wrote:
> lgtm, pending cbentzel ack that this approach is ok.

Thanks! I'll wait for cbentzel.

[cbentzel, 2014-06-11 17:33:52]

On 2014/06/11 08:21:55, Shuhei Takahashi wrote:
> On 2014/06/10 16:35:58, Ted C wrote:
> > lgtm, pending cbentzel ack that this approach is ok.
> 
> Thanks! I'll wait for cbentzel.

LGTM. thanks for explanation

[Shuhei Takahashi, 2014-06-12 01:58:48]

The CQ bit was checked by nya@chromium.org

[commit-bot: I haz the power, 2014-06-12 02:02:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nya@chromium.org/321943004/1

[commit-bot: I haz the power, 2014-06-12 08:12:03]

Change committed as 276579

[Shuhei Takahashi, 2014-06-12 09:08:15]

Hi Chris, Ted,

We'd like this change to be cherry-picked to M36 since
- the change is very small (disables prerender for 1% users), and 
- our related experiments will be delayed for months if we wait for M37.

I'm not familiar with process of cherry-picks. Could you give me advice?

Thanks,
Shuhei / nya

[cbentzel, 2014-06-12 13:31:15]

Mechanism for cherry-pick is that you go the bug and add labels

M-36
Merge-Requested

and the TPMs will make the call for whether or not the changes get merged.

However in this case I'm not sure I would support it. M36 is far along and this
is not fixing a regression, security hole, or anything else.

[Shuhei Takahashi, 2014-06-12 15:16:20]

On 2014/06/12 13:31:15, cbentzel wrote:
> Mechanism for cherry-pick is that you go the bug and add labels
> 
> M-36
> Merge-Requested
> 
> and the TPMs will make the call for whether or not the changes get merged.
> 
> However in this case I'm not sure I would support it. M36 is far along and
this
> is not fixing a regression, security hole, or anything else.

Thanks for explanation. I'll try it.

[cbentzel, 2014-06-12 17:47:27]

I'm not in favor of merging this.


On Thu, Jun 12, 2014 at 11:16 AM, <nya@chromium.org> wrote:

> On 2014/06/12 13:31:15, cbentzel wrote:
>
>> Mechanism for cherry-pick is that you go the bug and add labels
>>
>
>  M-36
>> Merge-Requested
>>
>
>  and the TPMs will make the call for whether or not the changes get merged.
>>
>
>  However in this case I'm not sure I would support it. M36 is far along and
>>
> this
>
>> is not fixing a regression, security hole, or anything else.
>>
>
> Thanks for explanation. I'll try it.
>
>
> https://codereview.chromium.org/321943004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Shuhei Takahashi, 2014-06-16 02:07:49]

I see, then we'll just wait for M37.


On 2014/06/12 17:47:27, cbentzel wrote:
> I'm not in favor of merging this.
> 
> 
> On Thu, Jun 12, 2014 at 11:16 AM, <mailto:nya@chromium.org> wrote:
> 
> > On 2014/06/12 13:31:15, cbentzel wrote:
> >
> >> Mechanism for cherry-pick is that you go the bug and add labels
> >>
> >
> >  M-36
> >> Merge-Requested
> >>
> >
> >  and the TPMs will make the call for whether or not the changes get merged.
> >>
> >
> >  However in this case I'm not sure I would support it. M36 is far along and
> >>
> > this
> >
> >> is not fixing a regression, security hole, or anything else.
> >>
> >
> > Thanks for explanation. I'll try it.
> >
> >
> > https://codereview.chromium.org/321943004/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.