Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 32193016: Make "git cl issue 0" idempotent. (Closed)

Created:
7 years, 2 months ago by teravest
Modified:
7 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Make "git cl issue 0" idempotent. Currently, running "git cl issue 0" in a client prints a confusing error message if there's no issue assigned. This changes the code so that the issue number isn't "unset" if it's not currently set. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=230499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
git_cl.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
7 years, 2 months ago (2013-10-23 20:04:37 UTC) #1
M-A Ruel
lgtm
7 years, 2 months ago (2013-10-23 20:06:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/32193016/1
7 years, 2 months ago (2013-10-23 20:06:24 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 20:09:09 UTC) #4
Message was sent while issue was closed.
Change committed as 230499

Powered by Google App Engine
This is Rietveld 408576698