WlanConnect to BSS with given frequency.

WlanConnect to BSS with given frequency. 

If desired frequency is specified, then highest link quality BSS with that frequency is passed to WlanConnect.


BUG=267667

[mef, 2013-10-23 19:54:54]

Hi Antoine,

I've prototyped using WLanConnect with desired bssid list, but I get error 50
(ERR_NOT_SUPPORTED) from call to wlan connect.

Do you have any ideas where to look?

thanks,
-m

[afontan, 2013-10-23 21:10:50]

Misha,

are you testing in windows 7 or 8? We only tested it in those platforms.

Antonio


On Wed, Oct 23, 2013 at 12:54 PM, <mef@chromium.org> wrote:

> Reviewers: afontan,
>
> Message:
> Hi Antoine,
>
> I've prototyped using WLanConnect with desired bssid list, but I get error
> 50
> (ERR_NOT_SUPPORTED) from call to wlan connect.
>
> Do you have any ideas where to look?
>
> thanks,
> -m
>
> Description:
> WlanConnect to BSS with given frequency.
> Work In Progress - Error 50.
>
> BUG=
>
> Please review this at
https://codereview.chromium.**org/32193015/<https://codereview.chromium.org/3...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files (+143, -20 lines):
>   M chrome/utility/networking_**private_handler.cc
>   M chrome/utility/wifi/wifi_**service.h
>   M chrome/utility/wifi/wifi_**service_mock.cc
>   M chrome/utility/wifi/wifi_**service_win.cc
>   M chrome/utility/wifi/wifi_test.**cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mef, 2013-10-24 17:51:43]

PTAL.

[afontan, 2013-10-24 18:18:20]

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/networking...
File chrome/utility/networking_private_handler.cc (right):

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/networking...
chrome/utility/networking_private_handler.cc:117:
WiFiService::kFrequencyUnknown,
I think that the name kFrequencyAny or kFrequencyUndefined  would represent a
bit better what this is but it is fine.

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/wifi/wifi_...
File chrome/utility/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/wifi/wifi_...
chrome/utility/wifi/wifi_service_win.cc:798: scoped_ptr<DOT11_BSSID_LIST>*
desired_list) {
I think you should consider adding hidden networks support in the extension as
it is a relatively common scenario.

[afontan, 2013-10-24 18:18:36]

lgtm

[mef, 2013-10-24 19:13:54]

Thanks, Antonio! 

Could you take one more look @ https://codereview.chromium.org/27722003/ (see my
comment below).

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/networking...
File chrome/utility/networking_private_handler.cc (right):

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/networking...
chrome/utility/networking_private_handler.cc:117:
WiFiService::kFrequencyUnknown,
On 2013/10/24 18:18:20, afontan wrote:
> I think that the name kFrequencyAny or kFrequencyUndefined  would represent a
> bit better what this is but it is fine.

Done.

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/wifi/wifi_...
File chrome/utility/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/32193015/diff/30001/chrome/utility/wifi/wifi_...
chrome/utility/wifi/wifi_service_win.cc:798: scoped_ptr<DOT11_BSSID_LIST>*
desired_list) {
On 2013/10/24 18:18:20, afontan wrote:
> I think you should consider adding hidden networks support in the extension as
it is a relatively common scenario.
Sounds good. I'll keep this CL going as placeholder for additional feature
support.

My current plan is to land http://crrev.com/22295002 first as the plumbing
support, then land https://codereview.chromium.org/27722003/ second as basic
Windows support, and then land this CL to support advanced scenarios.

[mef, 2013-10-24 22:12:09]

On 2013/10/24 19:13:54, mef wrote:
> Thanks, Antonio! 
> 
> Could you take one more look @ https://codereview.chromium.org/27722003/ (see
my
> comment below).
> 
>
https://codereview.chromium.org/32193015/diff/30001/chrome/utility/networking...
> File chrome/utility/networking_private_handler.cc (right):
> 
>
https://codereview.chromium.org/32193015/diff/30001/chrome/utility/networking...
> chrome/utility/networking_private_handler.cc:117:
> WiFiService::kFrequencyUnknown,
> On 2013/10/24 18:18:20, afontan wrote:
> > I think that the name kFrequencyAny or kFrequencyUndefined  would represent
a
> > bit better what this is but it is fine.
> 
> Done.
> 
>
https://codereview.chromium.org/32193015/diff/30001/chrome/utility/wifi/wifi_...
> File chrome/utility/wifi/wifi_service_win.cc (right):
> 
>
https://codereview.chromium.org/32193015/diff/30001/chrome/utility/wifi/wifi_...
> chrome/utility/wifi/wifi_service_win.cc:798: scoped_ptr<DOT11_BSSID_LIST>*
> desired_list) {
> On 2013/10/24 18:18:20, afontan wrote:
> > I think you should consider adding hidden networks support in the extension
as
> it is a relatively common scenario.
> Sounds good. I'll keep this CL going as placeholder for additional feature
> support.
> 
> My current plan is to land http://crrev.com/22295002 first as the plumbing
> support, then land https://codereview.chromium.org/27722003/ second as basic
> Windows support, and then land this CL to support advanced scenarios.

+tbarzic for extension knowledge.

I've experimented a little more with support of hidden networks by extension on
Windows and Chrome OS.
It doesn't seem to work on either OS. There is UI to 'Join other network' and it
appears to correctly pass
information to Chromecast, but it doesn't seem to call network private api to
connect to that (typed in) network,
so setup fails to find the device for the confirmation stage. I think it should
be possible and valuable.

thanks,
-m