Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: build/java_apk.gypi

Issue 321883002: Make test apks only dex files not in tested apk (proguard version) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index ff68354b28b07aa95da1253f8b1695f222022dcf..73fc3a59e53b4c9bed51b60a6140ab2415451a27 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -52,6 +52,7 @@
# never_lint - Set to 1 to not run lint on this target.
{
'variables': {
+ 'tested_apk_obfuscated_jar_path%': '/',
'tested_apk_dex_path%': '/',
'additional_input_paths': [],
'input_jars_paths': [],
@@ -158,8 +159,16 @@
# direct_dependent_settings, but a variable set by a direct_dependent_settings
# cannot be lifted in a dependent to all_dependent_settings.
'all_dependent_settings': {
+ 'conditions': [
+ ['proguard_enabled == "true"', {
+ 'variables': {
+ 'proguard_enabled': 'true',
Yaron 2014/06/11 00:45:26 How is this used?
cjhopman 2014/06/12 20:36:45 This sets proguard_enabled to 'true' in the test a
Yaron 2014/06/12 23:23:16 Oh, this is for the dex_action?
+ }
+ }],
+ ],
'variables': {
'apk_output_jar_path': '<(jar_path)',
+ 'tested_apk_obfuscated_jar_path': '<(obfuscated_jar_path)',
'tested_apk_dex_path': '<(dex_path)',
},
},
@@ -588,6 +597,7 @@
'<(instr_stamp)',
],
'outputs': [
+ '<(jar_path)',
'<(jar_stamp)',
'<(jar_path)',
],
@@ -604,16 +614,21 @@
'message': 'Obfuscating <(_target_name)',
'variables': {
'additional_obfuscate_options': [],
+ 'additional_obfuscate_input_paths': [],
'proguard_out_dir': '<(intermediate_dir)/proguard',
'proguard_input_jar_paths': [
'>@(input_jars_paths)',
'<(jar_path)',
],
- 'conditions': [
+ 'target_conditions': [
['is_test_apk == 1', {
'additional_obfuscate_options': [
+ '--tested-apk-obfuscated-jar-path', '>(tested_apk_obfuscated_jar_path)',
'--testapp',
],
+ 'additional_obfuscate_input_paths': [
+ '>(tested_apk_obfuscated_jar_path).info',
+ ],
}],
['proguard_enabled == "true"', {
'additional_obfuscate_options': [
@@ -621,6 +636,10 @@
],
}],
],
+ 'obfuscate_input_jars_paths': [
+ '>@(input_jars_paths)',
+ '<(jar_path)',
+ ],
},
'conditions': [
['is_test_apk == 1', {
@@ -633,15 +652,16 @@
'<(DEPTH)/build/android/gyp/apk_obfuscate.py',
'<(DEPTH)/build/android/gyp/util/build_utils.py',
'>@(proguard_flags_paths)',
+ '>@(obfuscate_input_jars_paths)',
+ '>@(additional_obfuscate_input_paths)',
'<(instr_stamp)',
],
'outputs': [
- # This lists obfuscate_stamp instead of obfuscated_jar_path because
- # ant only writes the latter if the md5 of the inputs changes.
'<(obfuscate_stamp)',
# In non-Release builds, these paths will all be empty files.
'<(obfuscated_jar_path)',
+ '<(obfuscated_jar_path).info',
'<(obfuscated_jar_path).dump',
'<(obfuscated_jar_path).seeds',
'<(obfuscated_jar_path).mapping',
@@ -657,15 +677,17 @@
'--android-sdk-jar', '<(android_sdk_jar)',
'--input-jars-paths=>(proguard_input_jar_paths)',
+ '--proguard-configs=>(proguard_flags_paths)',
+
+
'--test-jar-path', '<(test_jar_path)',
'--obfuscated-jar-path', '<(obfuscated_jar_path)',
'--proguard-jar-path', '<(android_sdk_root)/tools/proguard/lib/proguard.jar',
- '--proguard-config-files=<(proguard_flags_paths)',
'--stamp', '<(obfuscate_stamp)',
- '<@(additional_obfuscate_options)',
+ '>@(additional_obfuscate_options)',
],
},
{
@@ -695,8 +717,6 @@
'>(tested_apk_dex_path).inputs',
],
}],
- ],
- 'conditions': [
['proguard_enabled == "true"', {
'inputs': [ '<(obfuscate_stamp)' ]
}, {
« build/android/gyp/apk_obfuscate.py ('K') | « build/android/gyp/util/build_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698