Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 321873003: Add sampler options to SkScaledBitmapSampler (Closed)

Created:
6 years, 6 months ago by krajcevski
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add sampler options to SkScaledBitmapSampler Committed: https://skia.googlesource.com/skia/+/407d7c90224fccf39685c9cb091fd777b5aac3d9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simply SamplerOptions -> Options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -38 lines) Patch
M src/images/SkScaledBitmapSampler.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/images/SkScaledBitmapSampler.cpp View 1 17 chunks +56 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
krajcevski
6 years, 6 months ago (2014-06-09 20:10:52 UTC) #1
scroggo
On 2014/06/09 20:10:52, krajcevski wrote: lgtm
6 years, 6 months ago (2014-06-09 20:13:22 UTC) #2
hal.canary
LGTM https://codereview.chromium.org/321873003/diff/1/src/images/SkScaledBitmapSampler.h File src/images/SkScaledBitmapSampler.h (right): https://codereview.chromium.org/321873003/diff/1/src/images/SkScaledBitmapSampler.h#newcode37 src/images/SkScaledBitmapSampler.h:37: struct SamplerOptions { Since it's already namespaced, SkScaledBitmapSampler::Options ...
6 years, 6 months ago (2014-06-09 20:22:49 UTC) #3
krajcevski
https://codereview.chromium.org/321873003/diff/1/src/images/SkScaledBitmapSampler.h File src/images/SkScaledBitmapSampler.h (right): https://codereview.chromium.org/321873003/diff/1/src/images/SkScaledBitmapSampler.h#newcode37 src/images/SkScaledBitmapSampler.h:37: struct SamplerOptions { On 2014/06/09 20:22:49, Hal Canary wrote: ...
6 years, 6 months ago (2014-06-09 20:45:38 UTC) #4
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 6 months ago (2014-06-09 20:46:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/321873003/20001
6 years, 6 months ago (2014-06-09 20:46:18 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 21:29:15 UTC) #7
Message was sent while issue was closed. 
Change committed as 407d7c90224fccf39685c9cb091fd777b5aac3d9

Powered by Google App Engine
This is Rietveld 408576698