Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: tools/perf/page_sets/top_desktop_sites_2012Q3.py

Issue 321863003: Adding cloud permission buckets to pages sets that are part of crbug.com/374764 or already in cloud… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjustment for changes from review of 324503002 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/top_desktop_sites_2012Q3.py
diff --git a/tools/perf/page_sets/top_desktop_sites_2012Q3.py b/tools/perf/page_sets/top_desktop_sites_2012Q3.py
index a7e5bf59822b8ae49e55276e2020153e4f2a453c..f8b0b06fe64f8284aa38b78a32b989e788020c9a 100644
--- a/tools/perf/page_sets/top_desktop_sites_2012Q3.py
+++ b/tools/perf/page_sets/top_desktop_sites_2012Q3.py
@@ -3,14 +3,14 @@
# found in the LICENSE file.
# pylint: disable=W0401,W0614
from telemetry.page.actions.all_page_actions import *
-from telemetry.page.page_set import PageSet
-from telemetry.page.page import Page
+from telemetry.page import page_set
+from telemetry.page import page
-class Top2012Q3Page(Page):
+class Top2012Q3Page(page.Page):
- def __init__(self, url, page_set):
- super(Top2012Q3Page, self).__init__(url=url, page_set=page_set)
+ def __init__(self, url, page_set_in):
+ super(Top2012Q3Page, self).__init__(url=url, page_set=page_set_in)
aiolos (Not reviewing) 2014/06/10 20:08:41 This was done due to feedback in issue 324503002.
self.make_javascript_deterministic = True
self.credentials_path = 'data/credentials.json'
self.archive_data_file = 'data/2012Q3.json'
@@ -28,14 +28,15 @@ class Top2012Q3Page(Page):
self.ReloadAndGc(action_runner)
-class Top2012Q3PageSet(PageSet):
+class Top2012Q3PageSet(page_set.PageSet):
""" Pages hand-picked from top-lists in Q32012. """
def __init__(self):
super(Top2012Q3PageSet, self).__init__(
make_javascript_deterministic=True,
credentials_path='data/credentials.json',
- archive_data_file='data/2012Q3.json')
+ archive_data_file='data/2012Q3.json',
+ bucket=page_set.PARTNER_BUCKET)
urls_list = [
'http://www.facebook.com/barackobama',

Powered by Google App Engine
This is Rietveld 408576698