tools/perf/page_sets/key_desktop_sites.py - Issue 321863003: Adding cloud permission buckets to pages sets that are part of crbug.com/374764 or already in cloud…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_desktop_sites.py

Issue 321863003: Adding cloud permission buckets to pages sets that are part of crbug.com/374764 or already in cloud… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjustment for changes from review of 324503002 Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_desktop_sites.py

diff --git a/tools/perf/page_sets/key_desktop_sites.py b/tools/perf/page_sets/key_desktop_sites.py

index 6376aa3cf0c88445da35b16aa8895b4a02d892e1..b4e7da56c5f3a00e7fe0fda63584977f03f8b503 100644

--- a/tools/perf/page_sets/key_desktop_sites.py

+++ b/tools/perf/page_sets/key_desktop_sites.py

@@ -110,7 +110,8 @@ class KeyDesktopSitesPageSet(page_set_module.PageSet):

def __init__(self):

super(KeyDesktopSitesPageSet, self).__init__(

credentials_path='data/credentials.json',

- archive_data_file='data/key_desktop_sites.json')

+ archive_data_file='data/key_desktop_sites.json',

+ bucket=page_set_module.PARTNER_BUCKET)

self.AddPage(FacebookPage(self))

self.AddPage(GmailPage(self))

« no previous file with comments | « tools/perf/page_sets/intl_ko_th_vi.py ('k') | tools/perf/page_sets/key_mobile_sites.py » ('j') | tools/perf/page_sets/top_desktop_sites_2012Q3.py » ('J')