Adding cloud permission buckets to pages sets that are part of crbug.com/374764 or already in cloud…

Adding cloud permission buckets to pages sets that are part of crbug.com/374764 or already in cloud storage

Note that this must go in after the bucket permissions patch has landed.
https://codereview.chromium.org/324503002/

The following files are changed for crbug.com/374764
tools/perf/page_sets/page_cycler/bloat.py
tools/perf/page_sets/page_cycler/dhtml.py
tools/perf/page_sets/page_cycler/morejs.py
tools/perf/page_sets/page_cycler/moz.py

The rest of them are already in cloud storage, and have been added
to the same bucket as they are currently stored in. Verify by running:
telemetry/cloud_storage ls -r page_sets

BUG=356956
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276982

[aiolos (Not reviewing), 2014-06-10 20:08:41]

https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/top...
File tools/perf/page_sets/top_desktop_sites_2012Q3.py (right):

https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_desktop_sites_2012Q3.py:13: super(Top2012Q3Page,
self).__init__(url=url, page_set=page_set_in)
This was done due to feedback in issue 324503002. I think it might be better to
import page_set as page_set_module and leave this as page_set. That would be
consistent with the rest of the modules in this patch.

[tonyg, 2014-06-10 20:14:54]

lgtm

https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
File tools/perf/page_sets/tough_dom_memory_cases.py (right):

https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
tools/perf/page_sets/tough_dom_memory_cases.py:31:
bucket=page_set_module.PUBLIC_BUCKET)
This looks like it needs to be PARTNER

[aiolos (Not reviewing), 2014-06-10 20:23:59]

On 2014/06/10 20:14:54, tonyg wrote:
> lgtm
> 
>
https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
> File tools/perf/page_sets/tough_dom_memory_cases.py (right):
> 
>
https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
> tools/perf/page_sets/tough_dom_memory_cases.py:31:
> bucket=page_set_module.PUBLIC_BUCKET)
> This looks like it needs to be PARTNER

Done. 

Any preference on whether to keep Top2012Q3Page init as is, or change to
importing page_set_module?

[dtu, 2014-06-10 20:26:43]

On 2014/06/10 20:23:59, aiolos wrote:
> On 2014/06/10 20:14:54, tonyg wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
> > File tools/perf/page_sets/tough_dom_memory_cases.py (right):
> > 
> >
>
https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
> > tools/perf/page_sets/tough_dom_memory_cases.py:31:
> > bucket=page_set_module.PUBLIC_BUCKET)
> > This looks like it needs to be PARTNER
> 
> Done. 
> 
> Any preference on whether to keep Top2012Q3Page init as is, or change to
> importing page_set_module?

We frequently use ps to denote page set objects

[dtu, 2014-06-10 20:27:24]

lgtm

[aiolos (Not reviewing), 2014-06-10 20:29:59]

On 2014/06/10 20:26:43, dtu wrote:
> On 2014/06/10 20:23:59, aiolos wrote:
> > On 2014/06/10 20:14:54, tonyg wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
> > > File tools/perf/page_sets/tough_dom_memory_cases.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/321863003/diff/20001/tools/perf/page_sets/tou...
> > > tools/perf/page_sets/tough_dom_memory_cases.py:31:
> > > bucket=page_set_module.PUBLIC_BUCKET)
> > > This looks like it needs to be PARTNER
> > 
> > Done. 
> > 
> > Any preference on whether to keep Top2012Q3Page init as is, or change to
> > importing page_set_module?
> 
> We frequently use ps to denote page set objects

Ok, changed. Thanks.

[aiolos (Not reviewing), 2014-06-10 20:31:08]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2014-06-10 20:35:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aiolos@chromium.org/321863003/60001

[commit-bot: I haz the power, 2014-06-11 06:29:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 06:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 06:54:32]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tonyg, 2014-06-11 13:40:11]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:43:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aiolos@chromium.org/321863003/60001

[aiolos (Not reviewing), 2014-06-11 16:43:53]

The CQ bit was unchecked by aiolos@chromium.org

[aiolos (Not reviewing), 2014-06-11 16:43:59]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2014-06-11 16:45:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aiolos@chromium.org/321863003/60001

[commit-bot: I haz the power, 2014-06-11 20:55:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:28:23]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[tonyg, 2014-06-11 22:49:36]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:51:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aiolos@chromium.org/321863003/60001

[commit-bot: I haz the power, 2014-06-11 22:55:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 22:58:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:58:03]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[aiolos (Not reviewing), 2014-06-13 02:44:38]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2014-06-13 02:47:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aiolos@chromium.org/321863003/60001

[commit-bot: I haz the power, 2014-06-13 09:05:36]

Change committed as 276982