Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 321843002: Teach Ninja generator about 'AR' in 'make_global_settings' (Closed)

Created:
6 years, 6 months ago by yukawa
Modified:
6 years, 6 months ago
Reviewers:
Torne, scottmg
CC:
gyp-developer_googlegroups.com, Ami GONE FROM CHROMIUM
Visibility:
Public.

Description

Teach Ninja generator about 'AR' in 'make_global_settings' With this CL, 'AR' in 'make_global_settings' can be recognized by Ninja generator, like Make generator. This makes it easier for you to share the code among host/NaCl/NDK/Emscripten build targets. Note that 'AR.host' is not yet supported with this CL. BUG=gyp:434 TEST=unittest R=scottmg@chromium.org, torne@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1935

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M pylib/gyp/generator/ninja.py View 1 4 chunks +6 lines, -2 lines 0 comments Download
M test/make_global_settings/ar/gyptest-make_global_settings_ar.py View 1 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yukawa
Hi Scott, Torne, Can you take a look? I hope the diff of gyptest-make_global_settings_ar.py describes ...
6 years, 6 months ago (2014-06-09 17:58:38 UTC) #1
scottmg
lgtm
6 years, 6 months ago (2014-06-11 22:54:49 UTC) #2
yukawa
6 years, 6 months ago (2014-06-12 17:35:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698