Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py

Issue 321773002: [PowerProfiler] Make sure correct version of pySerial is imported with monsoon profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py b/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py
index 433797efd9ea5907aebfdfbcceddccbca2375907..a9c7dd7b9d15a3e05362009c3f42e2589c72534d 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py
@@ -5,6 +5,7 @@
import json
import unittest
+from telemetry.core import util
from telemetry.core.platform.power_monitor import monsoon_power_monitor
@@ -18,3 +19,24 @@ class MonsoonPowerMonitorTest(unittest.TestCase):
json.dumps(data))
self.assertEqual(results['power_samples_mw'], [1000, 4000, 9000, 16000])
self.assertEqual(results['energy_consumption_mwh'], 7500)
+
+ def testPySerialVersionNumber(self):
tonyg 2014/06/09 16:13:34 I think a better test would be to just import mons
+ util.AddDirToPythonPath(util.GetTelemetryDir(), 'third_party', 'pyserial')
+ import serial
+ try:
+ import serial.tools
+ import serial.tools.list_ports
+ self.assertTrue(True)
+ except ImportError:
+ self.assertTrue(True)
+
+ util.InsertDirInPythonPath(
+ 0, util.GetTelemetryDir(), 'third_party', 'pyserial')
+ import serial
+ self.assertEqual(serial.VERSION, '2.7')
+ try:
+ import serial.tools
+ import serial.tools.list_ports
+ self.assertTrue(True)
+ except ImportError:
+ self.assertTrue(False)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/profiler/monsoon.py » ('j') | tools/telemetry/telemetry/core/util.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698