tools/telemetry/telemetry/core/platform/profiler/monsoon_unittest.py - Issue 321773002: [PowerProfiler] Make sure correct version of pySerial is imported with monsoon profiler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/core/platform/profiler/monsoon_unittest.py

Issue 321773002: [PowerProfiler] Make sure correct version of pySerial is imported with monsoon profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added missing license text Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 import unittest

5	6

6 class TimelineRecordingOptions(object):	7 class MonsoonImportTest(unittest.TestCase):

7 def __init__(self):	8 def testPySerialVersion(self):

8 self.record_timeline = True	9 from telemetry.core.platform.profiler import monsoon

9 self.record_network = False	10 self.assertEqual(monsoon.serial.VERSION, '2.7')
	qsr 2014/06/11 08:21:51 Shouldn't this be in some util_unittest.py ? You s Shouldn't this be in some util_unittest.py ? You should import serial from there and test VERSION, instead of relying on internal implementation details of the monsoon file.
OLD	NEW

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/util.py » ('j') | no next file with comments »