Don't clear exception pending message if we have externally TryCatch and finally on top of stack.

V8 can clear exception pending message, when should not do this.

The case:
v8::TryCatch try_catch;
CompileRun(try { CEvaluate('throw 1;'); } finally {});
CHECK(try_catch.HasCaught());
CHECK(!try_catch.Message().IsEmpty());

CEvaluate is native call. Last check is not passed without patch. Patch contains test TryCatchFinallyStoresMessageUsingTryCatchHandler with more details.

R=yangguo@chromium.org, mstarzinger@chromium.org, vsevik@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21755

[kozyatinskiy1, 2014-06-09 08:24:46]

Yang and Michael, Could you please have a look on last patch set?

[kozyatinskiy1, 2014-06-09 11:26:33]

This patch continues https://codereview.chromium.org/306463002/

First patch set is last reviewed patch set from
https://codereview.chromium.org/306463002/

Second patch set have fixed bug with ASSERT(!handler->is_catch()) in
Isolate::IsFinallyOnTop(). It is essentially to not check IsFinallyOnTop in all
case except has_external_try_catch is true and is_catchable_by_javascript is
true.

[Yang, 2014-06-10 14:57:45]

lgtm with comment.

https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc#newcode1732
src/isolate.cc:1732: if (is_finally_on_top) {
can't we just
if (IsFinallyOnTop()) ...
?

[kozyatinskiy1, 2014-06-10 15:35:24]

On 2014/06/10 14:57:45, Yang wrote:
> lgtm with comment.
> 
> https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc
> File src/isolate.cc (right):
> 
>
https://codereview.chromium.org/321763002/diff/20001/src/isolate.cc#newcode1732
> src/isolate.cc:1732: if (is_finally_on_top) {
> can't we just
> if (IsFinallyOnTop()) ...
> ?

Yes, done.

[yurys, 2014-06-11 05:48:41]

Committed patchset #3 manually as r21755 (presubmit successful).