Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 321753003: Files.app: Fix the bug on search (Closed)

Created:
6 years, 6 months ago by yoshiki
Modified:
6 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Files.app: Fix the bug on search On search on Files.app, it fails due to exception, because of the regression caused by r275418. This patch fixes it. BUG=382332 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yoshiki
@mtomasz: PTAL. Thanks,
6 years, 6 months ago (2014-06-09 07:52:12 UTC) #1
mtomasz
Thx for fixing quickly. LGTM!
6 years, 6 months ago (2014-06-09 07:54:13 UTC) #2
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 6 months ago (2014-06-09 08:01:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/321753003/1
6 years, 6 months ago (2014-06-09 08:01:48 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 11:21:39 UTC) #5
Message was sent while issue was closed.
Change committed as 275791

Powered by Google App Engine
This is Rietveld 408576698