Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 32173002: Revert r159668 "CSSPropertyTextIndent should be a member of css3TextProperties." (Closed)

Created:
7 years, 2 months ago by dw.im
Modified:
7 years, 2 months ago
CC:
blink-reviews, Bear Travis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert r159668 "CSSPropertyTextIndent should be a member of css3TextProperties." CSSPropertyTextIndent shouldn't be a member of RuntimeEnabledFeatures::css3TextProperties. This is the reason why we meet crash when run virtual/stable/webexposed/nonstable-css-properties.html in debug mode. Even though the original patch has a test case for text-align-last, reverting the original one is better to avoid confusion. And, I will upload another patch to add the test case for text-align-last. BUG=308314 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160164

Patch Set 1 #

Patch Set 2 : Revert the original patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/nonstable-css-properties-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dw.im
7 years, 2 months ago (2013-10-21 10:27:07 UTC) #1
Julien - ping for review
Can't we just revert the original change using drover? This change is confusing as it ...
7 years, 2 months ago (2013-10-21 15:55:28 UTC) #2
dw.im
On 2013/10/21 15:55:28, Julien Chaffraix wrote: > Can't we just revert the original change using ...
7 years, 2 months ago (2013-10-21 23:54:52 UTC) #3
Julien - ping for review
lgtm I would much prefer if the description did mention explicitly that it's a revert ...
7 years, 2 months ago (2013-10-22 00:59:17 UTC) #4
dw.im
On 2013/10/22 00:59:17, Julien Chaffraix wrote: > lgtm > > I would much prefer if ...
7 years, 2 months ago (2013-10-22 01:05:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dw.im@samsung.com/32173002/60001
7 years, 2 months ago (2013-10-22 01:07:03 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 09:14:03 UTC) #7
Message was sent while issue was closed.
Change committed as 160164

Powered by Google App Engine
This is Rietveld 408576698