Reland "Clean up Test's resourcePath code."

Reland "Clean up Test's resourcePath code."

This relands commit 91359bed48bc006a4319da86eb26db3b2e6d4afb (Clean up
Test's resourcePath code."

BUG=None
TEST=make dm && out/Debug/dm
R=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/880914c35c8f7fc2e9c57134134c883baf66e538

[tfarina, 2014-06-08 20:01:17]

Mike, ptal.

Fix is in patch set 2.

[mtklein, 2014-06-09 14:55:08]

On 2014/06/08 20:01:17, tfarina wrote:
> Mike, ptal.
> 
> Fix is in patch set 2.

lgtm

I'm still not very satisfied with all this code.  I've got some ideas about how
to improve them:
  - remove all the resource path plumbing code from gm.h / Test.h /
SkBenchmark.h, their .cpp's, and from gmmain.cpp / skia_test.cpp / benchmain.cpp
/ DM.cpp
  - create a small new library to handle resource access, something like this:

tools/resources.h:
#ifndef resources_DEFINED
#define resources_DEFINED

#include "SkString.h"

SkString GetResourcePath(const char* resource = "");

#endif//resources_DEFINED

tools/resources.cpp:
#include "resources.h"

#include "SkCommandLineFlags.h"
#include "SkOSFile.h"

DEFINE_string2(resourcePath, i, "resources", "Directory with test resources:
images, fonts, etc.");

SkString GetResourcePath(const char* resource) {
    return SkOSPath::SkPathJoin(FLAGS_resourcePath[0], resource);
}

Then, every bit of code that needs resources can #include "resources.h"
themselves and call GetResourcePath().

Any interest in working on something like this?

[tfarina, 2014-06-09 18:00:53]

Hey Mike, I'm very happy to work on this.

I'll prepare a patch to work on your suggestion in a follow up CL.

Thanks for the proposal!

[tfarina, 2014-06-09 18:31:39]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-09 18:32:27]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/321723002/40001

[commit-bot: I haz the power, 2014-06-09 19:05:39]

Change committed as 880914c35c8f7fc2e9c57134134c883baf66e538