Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 321703002: Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (Closed)

Created:
6 years, 6 months ago by ckocagil
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (https://codereview.chromium.org/324523002/) Reason for revert: Breaks Linux ASAN http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2865 Original issue's description: > Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms. > > BUG=239879 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275716 TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org NOTREECHECKS=true NOTRY=true BUG=239879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -243 lines) Patch
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +11 lines, -5 lines 0 comments Download
M chrome/browser/resources/print_preview/data/ticket_items/color.js View 2 chunks +36 lines, -64 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 3 chunks +4 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 8 chunks +81 lines, -6 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_cdd_conversion.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 4 chunks +44 lines, -136 lines 0 comments Download
M printing/backend/print_backend.h View 1 chunk +10 lines, -0 lines 0 comments Download
M printing/backend/print_backend.cc View 1 chunk +4 lines, -1 line 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ckocagil
Created Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable ...
6 years, 6 months ago (2014-06-08 07:55:32 UTC) #1
ckocagil
6 years, 6 months ago (2014-06-08 09:05:13 UTC) #2
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/318293002/ by ckocagil@chromium.org.

The reason for reverting is: Didn't fix..

Powered by Google App Engine
This is Rietveld 408576698