Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/picture_utils.h

Issue 321693002: Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rm is_path_seperator() Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bench_pictures_main.cpp ('k') | tools/picture_utils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/picture_utils.h
diff --git a/tools/picture_utils.h b/tools/picture_utils.h
index c0e0d2c8dd5ee6872ac2784ddcd00e455916fdfc..2e1af7b78c1bb75ff012b7e3abd87aa01bf98d95 100644
--- a/tools/picture_utils.h
+++ b/tools/picture_utils.h
@@ -38,13 +38,6 @@ namespace sk_tools {
// TODO(epoger): delete in favor of SkOSPath::SkPathJoin()?
void make_filepath(SkString* path, const SkString&, const SkString& name);
- // Returns the last part of the path (file name or leaf directory name)
- //
- // This basically just looks for a foward slash or backslash (windows
- // only).
- // TODO(epoger): delete in favor of SkOSPath::SkBasename()?
- void get_basename(SkString* basename, const SkString& path);
-
// Returns true if the string ends with %
bool is_percentage(const char* const string);
« no previous file with comments | « tools/bench_pictures_main.cpp ('k') | tools/picture_utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698