Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Side by Side Diff: tests/PictureUtilsTest.cpp

Issue 321693002: Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rm is_path_seperator() Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/bench_pictures_main.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "picture_utils.h"
9
8 #include "SkString.h" 10 #include "SkString.h"
9 #include "Test.h" 11 #include "Test.h"
10 #include "picture_utils.h"
11 12
12 static void test_filepath_creation(skiatest::Reporter* reporter) { 13 DEF_TEST(PictureUtils, reporter) {
13 SkString result; 14 SkString result;
14 SkString filename("test"); 15 SkString filename("test");
15 SkString dir("test/path"); 16 SkString dir("test/path");
16 sk_tools::make_filepath(&result, dir, filename); 17 sk_tools::make_filepath(&result, dir, filename);
17 REPORTER_ASSERT(reporter, result.equals("test/path/test")); 18 REPORTER_ASSERT(reporter, result.equals("test/path/test"));
18 } 19 }
19
20 static void test_get_basename(skiatest::Reporter* reporter) {
21 SkString result;
22 SkString path("/path/basename");
23 sk_tools::get_basename(&result, path);
24 REPORTER_ASSERT(reporter, result.equals("basename"));
25
26 result.reset();
27 path.set("/path/dir/");
28 sk_tools::get_basename(&result, path);
29 REPORTER_ASSERT(reporter, result.equals("dir"));
30
31 result.reset();
32 path.set("path");
33 sk_tools::get_basename(&result, path);
34 REPORTER_ASSERT(reporter, result.equals("path"));
35
36 #if defined(SK_BUILD_FOR_WIN)
37 result.reset();
38 path.set("path\\winbasename");
39 sk_tools::get_basename(&result, path);
40 REPORTER_ASSERT(reporter, result.equals("winbasename"));
41
42 result.reset();
43 path.set("path\\windir\\");
44 sk_tools::get_basename(&result, path);
45 REPORTER_ASSERT(reporter, result.equals("windir"));
46 #endif
47 }
48
49 DEF_TEST(PictureUtils, reporter) {
50 test_filepath_creation(reporter);
51 test_get_basename(reporter);
52 }
OLDNEW
« no previous file with comments | « no previous file | tools/bench_pictures_main.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698