Issue 321693002: Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321693002: Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename(). (Closed)

Created:
6 years, 6 months ago by tfarina

Modified:
6 years, 6 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename(). BUG=None TEST=make tests && out/Debug/tests R=epoger@google.com Committed: https://skia.googlesource.com/skia/+/1c99ea8ed80ca492397717b57e2735869be38c69

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -92 lines)			Patch
M	tests/PictureUtilsTest.cpp	View		1 chunk	+3 lines, -36 lines	0 comments	Download
M	tools/bench_pictures_main.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/picture_utils.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	tools/picture_utils.cpp	View	1	2 chunks	+0 lines, -41 lines	0 comments	Download
M	tools/render_pdfs_main.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

tfarina

Is this OK Elliot? The implementation of get_basename is much more involved that SkBasename.

6 years, 6 months ago (2014-06-08 01:26:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/321693002/20001

6 years, 6 months ago (2014-06-11 15:47:29 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-11 15:58:55 UTC) #5

Message was sent while issue was closed.

Change committed as 1c99ea8ed80ca492397717b57e2735869be38c69