Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 321663002: Revert of Delete CompositingUpdateAfterLayout (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
esprehn, abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Revert of Delete CompositingUpdateAfterLayout (https://codereview.chromium.org/323653002/) Reason for revert: Triggers ASSERT when running browser_test CastStreamingApiTestWithPixelOutput.RtpStreamError Original issue's description: > Delete CompositingUpdateAfterLayout > > Rather than using a different update type, we can just mark the root as needing > its properties updated, which will cause us to update the entire tree. This CL > alone isn't a huge win, but it will let us remove > RenderLayerCompositor::m_compositingLayersNeedRebuild in the next CL. > > Also, move the call to enableCompositingModeIfNeeded into the new > RenderLayerCompositor::didLayout function. This makes the sequence look a bit > silly (because we mark the dirty bit only to clear it immediately), but that's > what the code did before (albeit in a more roundabout way). > > BUG=332248 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175738 TBR=esprehn@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=332248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Delete CompositingUpdateAfterLayout
6 years, 6 months ago (2014-06-07 09:13:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/321663002/1
6 years, 6 months ago (2014-06-07 09:13:54 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 09:14:24 UTC) #3
Message was sent while issue was closed.
Change committed as 175742

Powered by Google App Engine
This is Rietveld 408576698