Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: build/android/pylib/android_commands.py

Issue 32163002: Relands Android perf tests: kill adbd on the device after running a test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pliard's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/perf/test_runner.py » ('j') | build/android/pylib/perf/test_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/android_commands.py
diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py
index 20684b7b07b317b870370d8476eb237f6cbffe23..c1f25eb200add21cc388b7fe5d7fac328bfc9576 100644
--- a/build/android/pylib/android_commands.py
+++ b/build/android/pylib/android_commands.py
@@ -458,6 +458,14 @@ class AndroidCommands(object):
if out.strip() != 'remount succeeded':
raise errors.MsgException('Remount failed: %s' % out)
+ def RestartAdbdOnDevice(self):
+ logging.info('Killing adbd on the device...')
+ adb_pids = self.ExtractPid('adbd')
+ if adb_pids:
tonyg 2013/10/21 17:48:39 Should we assert adb_pids? There is no way we'd be
bulach 2013/10/21 18:49:40 Done.
+ self.RunShellCommandWithSU('kill %s' % ' '.join(adb_pids))
tonyg 2013/10/21 17:48:39 We already have a KillAll() method in this class.
bulach 2013/10/21 18:49:40 Done.
+ logging.info('Waiting for device to settle...')
+ self._adb.SendCommand('wait-for-device')
+
def RestartAdbServer(self):
"""Restart the adb server."""
ret = self.KillAdbServer()
« no previous file with comments | « no previous file | build/android/pylib/perf/test_runner.py » ('j') | build/android/pylib/perf/test_runner.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698