Relands Android perf tests: kill adbd on the device after running a test.

build/android/pylib/android_commands.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides an interface to communicate with the device via the adb command.
 
 Assumes adb binary is currently on system path.
 """
 
 import collections
@@ skipping 440 matching lines @@
         # Force a hard reboot on last attempt
         self.Reboot(full_reboot=(reboots_left == 1))
         reboots_left -= 1
 
   def MakeSystemFolderWritable(self):
     """Remounts the /system folder rw."""
     out = self._adb.SendCommand('remount')
     if out.strip() != 'remount succeeded':
       raise errors.MsgException('Remount failed: %s' % out)
 
+  def KillAdbdDevice(self):

[rmcilroy, 2013/10/21 11:33:13]

Nit - how about RestartAdbdOnDevice()?

[bulach, 2013/10/21 15:30:13]

Done.

+    logging.info('Killing adbd on the device...')
+    adb_pids = self.ExtractPid('adbd')
+    if adb_pids:
+      self.RunShellCommandWithSU('kill %s' % ' '.join(adb_pids))
+    logging.info('Waiting for device to settle...')

[rmcilroy, 2013/10/21 11:33:13]

Nit - "Waiting for adbd to restart on device..." ?  Also, is there any way to
get the serial number here (and above in "killing...")?

[bulach, 2013/10/21 15:30:13]

yes! :) thankfully, it's already done at a lower level:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...

+    self._adb.SendCommand('wait-for-device')
+
   def RestartAdbServer(self):
     """Restart the adb server."""
     ret = self.KillAdbServer()
     if ret != 0:
       raise errors.MsgException('KillAdbServer: %d' % ret)
 
     ret = self.StartAdbServer()
     if ret != 0:
       raise errors.MsgException('StartAdbServer: %d' % ret)
 
@@ skipping 1170 matching lines @@
   """
   def __init__(self, output):
     self._output = output
 
   def write(self, data):
     data = data.replace('\r\r\n', '\n')
     self._output.write(data)
 
   def flush(self):
     self._output.flush()