Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 321613002: ServiceWorker browser test fix (Closed)

Created:
6 years, 6 months ago by michaeln
Modified:
6 years, 6 months ago
Reviewers:
falken
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Fix a browser tests to immediately grab a reference to the a response blob instead of deferring it. BUG=381827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275624

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 3 4 5 12 chunks +37 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
michaeln
ptal i had started out trying to have the version grab the version immedately upon ...
6 years, 6 months ago (2014-06-06 22:55:39 UTC) #1
michaeln
errr... "grab the reference immedately"
6 years, 6 months ago (2014-06-06 22:56:19 UTC) #2
michaeln
https://codereview.chromium.org/321613002/diff/40001/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/321613002/diff/40001/content/browser/service_worker/service_worker_browsertest.cc#newcode316 content/browser/service_worker/service_worker_browsertest.cc:316: FetchResult fetch_result; ooops, this isn't right yet
6 years, 6 months ago (2014-06-06 22:59:24 UTC) #3
michaeln
ok, should be fixed now
6 years, 6 months ago (2014-06-06 23:31:56 UTC) #4
falken
lgtm with a suggestion https://codereview.chromium.org/321613002/diff/60001/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/321613002/diff/60001/content/browser/service_worker/service_worker_browsertest.cc#newcode107 content/browser/service_worker/service_worker_browsertest.cc:107: webkit_blob::BlobDataHandle* blob_data_handle) { Would it ...
6 years, 6 months ago (2014-06-06 23:55:50 UTC) #5
michaeln
https://codereview.chromium.org/321613002/diff/60001/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/321613002/diff/60001/content/browser/service_worker/service_worker_browsertest.cc#newcode107 content/browser/service_worker/service_worker_browsertest.cc:107: webkit_blob::BlobDataHandle* blob_data_handle) { On 2014/06/06 23:55:50, falken wrote: > ...
6 years, 6 months ago (2014-06-07 00:00:02 UTC) #6
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 6 months ago (2014-06-07 00:03:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/321613002/100001
6 years, 6 months ago (2014-06-07 00:04:38 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 05:20:53 UTC) #9
Message was sent while issue was closed.
Change committed as 275624

Powered by Google App Engine
This is Rietveld 408576698