Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 321583004: Update deleteSelection callsites after r164025 (Closed)

Created:
6 years, 6 months ago by pdr.
Modified:
6 years, 6 months ago
Reviewers:
adamk
CC:
blink-reviews
Visibility:
Public.

Description

Update deleteSelection callsites after r164025 This patch fixes the deleteSelection callsites in CompositeEditCommand after [1] refactored them to remove the bool 'replace' parameter. [1] http://src.chromium.org/viewvc/blink?revision=164025&view=revision BUG=381069 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/editing/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pdr.
6 years, 6 months ago (2014-06-06 21:23:25 UTC) #1
adamk
lgtm
6 years, 6 months ago (2014-06-06 21:54:26 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-06 22:13:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/321583004/1
6 years, 6 months ago (2014-06-06 22:14:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 23:38:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 23:46:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10700)
6 years, 6 months ago (2014-06-06 23:46:52 UTC) #7
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-07 01:02:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/321583004/1
6 years, 6 months ago (2014-06-07 01:02:16 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:38:55 UTC) #10
Message was sent while issue was closed.
Change committed as 175727

Powered by Google App Engine
This is Rietveld 408576698