Issue 321573002: Remove CompositingUpdateAfterStyleChange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 321573002: Remove CompositingUpdateAfterStyleChange (Closed)

Created:
6 years, 6 months ago by abarth-chromium

Modified:
6 years, 6 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, Ian Vollick, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove CompositingUpdateAfterStyleChange CompositingUpdateAfterStyleChange does the same thing as CompositingUpdateAfterCompositingInputChange. There's no reason to have two enums. Also, I've inlined FrameView::updateCompositingLayersAfterStyleChange because that function just contained a redundant null check. BUG=332248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175694

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -12 lines)			Patch
M	Source/core/dom/Document.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/frame/FrameView.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	1 chunk	+0 lines, -8 lines	1 comment	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/321573002/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (left): https://codereview.chromium.org/321573002/diff/1/Source/core/frame/FrameView.cpp#oldcode643 Source/core/frame/FrameView.cpp:643: void FrameView::updateCompositingLayersAfterStyleChange() I considered removing this method and ...

6 years, 6 months ago (2014-06-06 18:35:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/321573002/1

6 years, 6 months ago (2014-06-06 18:36:13 UTC) #3

Message was sent while issue was closed.

Change committed as 175694

Expand Messages | Collapse Messages