Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/page_sets/tough_energy_cases.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/tough_compositor_cases.py ('k') | tools/perf/page_sets/tough_pinch_zoom_cases.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_energy_cases.py
diff --git a/tools/perf/page_sets/tough_energy_cases.py b/tools/perf/page_sets/tough_energy_cases.py
index 38de3b67ecdfda1fa0775ba29f82bfa30c75f0aa..e5b148666cae1d2a56a6c3d996f30771a58d7533 100644
--- a/tools/perf/page_sets/tough_energy_cases.py
+++ b/tools/perf/page_sets/tough_energy_cases.py
@@ -27,12 +27,9 @@ class GmailPage(ToughEnergyCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'javascript': (
- 'window.gmonkey !== undefined &&'
- 'document.getElementById("gb") !== null')
- }))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.gmonkey !== undefined &&'
+ 'document.getElementById("gb") !== null')
class ToughEnergyCasesPageSet(page_set_module.PageSet):
« no previous file with comments | « tools/perf/page_sets/tough_compositor_cases.py ('k') | tools/perf/page_sets/tough_pinch_zoom_cases.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698