tools/perf/page_sets/tough_canvas_cases.py - Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_canvas_cases.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/tough_animation_cases.py ('k') | tools/perf/page_sets/tough_compositor_cases.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/tough_canvas_cases.py

diff --git a/tools/perf/page_sets/tough_canvas_cases.py b/tools/perf/page_sets/tough_canvas_cases.py

index b70b51eec4eeb23d7f722415024a87d8d52637e4..0df8d498435cf2ba90d05d835fe885b4cf5d77ca 100644

--- a/tools/perf/page_sets/tough_canvas_cases.py

+++ b/tools/perf/page_sets/tough_canvas_cases.py

@@ -15,16 +15,11 @@ class ToughCanvasCasesPage(page_module.Page):

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

- action_runner.RunAction(WaitAction(

- {

- "javascript": "document.readyState == 'complete'"

- }))

+ action_runner.WaitForJavaScriptCondition(

+ "document.readyState == 'complete'")

def RunSmoothness(self, action_runner):

- action_runner.RunAction(WaitAction(

- {

- "seconds": 5

- }))

+ action_runner.Wait(5)

class MicrosofFirefliesPage(ToughCanvasCasesPage):