tools/perf/page_sets/service_worker.py - Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/service_worker.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/service_worker.py

diff --git a/tools/perf/page_sets/service_worker.py b/tools/perf/page_sets/service_worker.py

index 934b9fbff9245646b1230850402877340ca9a295..b2a38df9f4b9367e3696e5b657422ba27b7a9314 100644

--- a/tools/perf/page_sets/service_worker.py

+++ b/tools/perf/page_sets/service_worker.py

@@ -13,7 +13,7 @@ archive_data_file_path = 'data/service_worker.json'

class ServiceWorkerPage(page.Page):

def RunNavigateSteps(self, action_runner):

action_runner.RunAction(actions.NavigateAction())

- action_runner.RunAction(actions.WaitAction({'javascript': 'window.done'}))

+ action_runner.WaitForJavaScriptCondition('window.done')

class ServiceWorkerPageSet(page_set.PageSet):

« no previous file with comments | « tools/perf/page_sets/polymer.py ('k') | tools/perf/page_sets/startup_pages.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')