tools/perf/page_sets/browser_control_click.py - Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/browser_control_click.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/browser_control.py ('k') | tools/perf/page_sets/calendar_forward_backward.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/browser_control_click.py

diff --git a/tools/perf/page_sets/browser_control_click.py b/tools/perf/page_sets/browser_control_click.py

index acb4e9d5858dc306e5f5bd062e7d46c7538429e1..72c55a477cba35a0cc889ed2872184a353150f35 100644

--- a/tools/perf/page_sets/browser_control_click.py

+++ b/tools/perf/page_sets/browser_control_click.py

@@ -22,29 +22,19 @@ class BrowserControlClickPage(page_module.Page):

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

- action_runner.RunAction(WaitAction(

- {

- 'xpath': 'id("attach")',

- 'condition': 'element'

- }))

+ action_runner.WaitForElement('#attach')

def RunEndure(self, action_runner):

action_runner.RunAction(ClickElementAction(

{

'xpath': 'id("attach")'

}))

- action_runner.RunAction(WaitAction(

- {

- 'seconds': 0.5

- }))

+ action_runner.Wait(0.5)

action_runner.RunAction(ClickElementAction(

{

'xpath': 'id("detach")'

}))

- action_runner.RunAction(WaitAction(

- {

- 'seconds': 0.5

- }))

+ action_runner.Wait(0.5)

class BrowserControlClickPageSet(page_set_module.PageSet):