tools/perf/benchmarks/maps.py - Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/maps.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/page_sets/pixel_tests.py ('k') | tools/perf/measurements/polymer_load.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/benchmarks/maps.py

diff --git a/tools/perf/benchmarks/maps.py b/tools/perf/benchmarks/maps.py

index 7acda862b91ddd0796530b3fba3972b4f07a4479..ef84b4b735a3604f8ef0596e53aa1485675697ed 100644

--- a/tools/perf/benchmarks/maps.py

+++ b/tools/perf/benchmarks/maps.py

@@ -36,7 +36,7 @@ class MapsPage(page_module.Page):

def RunNavigateSteps(self, action_runner):

action_runner.NavigateToPage(self)

- action_runner.RunAction(WaitAction({'javascript': 'window.testDone'}))

+ action_runner.WaitForJavaScriptCondition('window.testDone')

@test.Disabled