Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: content/test/gpu/gpu_tests/context_lost.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/gpu/gpu_tests/context_lost.py
diff --git a/content/test/gpu/gpu_tests/context_lost.py b/content/test/gpu/gpu_tests/context_lost.py
index 5a05d83d08fbf89098704b2926bad8e6ba4e693e..ef1e57642fdff400278ddb9b9299edf096c7c05e 100644
--- a/content/test/gpu/gpu_tests/context_lost.py
+++ b/content/test/gpu/gpu_tests/context_lost.py
@@ -138,8 +138,8 @@ class WebGLContextLostFromGPUProcessExitPage(page.Page):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {'javascript': 'window.domAutomationController._loaded'}))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.domAutomationController._loaded')
class WebGLContextLostFromLoseContextExtensionPage(page.Page):
@@ -155,8 +155,8 @@ class WebGLContextLostFromLoseContextExtensionPage(page.Page):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {'javascript': 'window.domAutomationController._finished'}))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.domAutomationController._finished')
class WebGLContextLostFromQuantityPage(page.Page):
def __init__(self, page_set, base_dir):
@@ -171,8 +171,8 @@ class WebGLContextLostFromQuantityPage(page.Page):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {'javascript': 'window.domAutomationController._loaded'}))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.domAutomationController._loaded')
class ContextLost(test_module.Test):
enabled = True
@@ -190,5 +190,3 @@ class ContextLost(test_module.Test):
ps.AddPage(WebGLContextLostFromLoseContextExtensionPage(ps, ps.base_dir))
ps.AddPage(WebGLContextLostFromQuantityPage(ps, ps.base_dir))
return ps
-
-
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/maps.py » ('j') | tools/telemetry/telemetry/page/actions/action_runner.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698