Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/perf/page_sets/tough_webgl_cases.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/tough_video_cases.py ('k') | tools/perf/page_sets/webrtc_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_webgl_cases.py
diff --git a/tools/perf/page_sets/tough_webgl_cases.py b/tools/perf/page_sets/tough_webgl_cases.py
index 3263eb7e8bbf5dfdeb74a9297f3d0d46ad6d4b23..69ebb0e7f746aa16862571c915aecd63dffa7d2c 100644
--- a/tools/perf/page_sets/tough_webgl_cases.py
+++ b/tools/perf/page_sets/tough_webgl_cases.py
@@ -23,14 +23,12 @@ class ToughWebglCasesPage(page_module.Page):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'javascript': 'document.readyState == "complete"'
- }))
- action_runner.RunAction(WaitAction({'seconds': 2}))
+ action_runner.WaitForJavaScriptCondition(
+ 'document.readyState == "complete"')
+ action_runner.Wait(2)
def RunSmoothness(self, action_runner):
- action_runner.RunAction(WaitAction({'seconds': 5}))
+ action_runner.Wait(5)
class Page1(ToughWebglCasesPage):
@@ -46,11 +44,9 @@ class Page1(ToughWebglCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'javascript': 'document.readyState == "complete"'
- }))
- action_runner.RunAction(WaitAction({'seconds': 15}))
+ action_runner.WaitForJavaScriptCondition(
+ 'document.readyState == "complete"')
+ action_runner.Wait(15)
class Page2(ToughWebglCasesPage):
@@ -62,11 +58,9 @@ class Page2(ToughWebglCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'javascript': 'document.readyState == "complete"'
- }))
- action_runner.RunAction(WaitAction({'seconds': 10}))
+ action_runner.WaitForJavaScriptCondition(
+ 'document.readyState == "complete"')
+ action_runner.Wait(10)
class ToughWebglCasesPageSet(page_set_module.PageSet):
« no previous file with comments | « tools/perf/page_sets/tough_video_cases.py ('k') | tools/perf/page_sets/webrtc_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698