Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: tools/perf/page_sets/tough_pinch_zoom_cases.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/tough_energy_cases.py ('k') | tools/perf/page_sets/tough_scheduling_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_pinch_zoom_cases.py
diff --git a/tools/perf/page_sets/tough_pinch_zoom_cases.py b/tools/perf/page_sets/tough_pinch_zoom_cases.py
index a68dbd68e46161c881c3cfd37ea19ce1cd13dc1e..d658bffb5717b94072b27955012eb1273a1e5725 100644
--- a/tools/perf/page_sets/tough_pinch_zoom_cases.py
+++ b/tools/perf/page_sets/tough_pinch_zoom_cases.py
@@ -31,11 +31,7 @@ class GoogleSearchPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'text': 'Next',
- 'condition': 'element'
- }))
+ action_runner.WaitForElement(text='Next')
class GmailPage(ToughPinchZoomCasesPage):
@@ -51,12 +47,9 @@ class GmailPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'javascript' : (
- 'window.gmonkey !== undefined &&'
- 'document.getElementById("gb") !== null')
- }))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.gmonkey !== undefined &&'
+ 'document.getElementById("gb") !== null')
class GoogleCalendarPage(ToughPinchZoomCasesPage):
@@ -72,7 +65,7 @@ class GoogleCalendarPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction({'seconds':2}))
+ action_runner.Wait(2)
def RunSmoothness(self, action_runner):
action_runner.RunAction(PinchAction(
@@ -107,11 +100,7 @@ class GooglePlusPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'text': 'Home',
- 'condition': 'element'
- }))
+ action_runner.WaitForElement(text='Home')
def RunSmoothness(self, action_runner):
action_runner.RunAction(PinchAction(
@@ -136,7 +125,7 @@ class YoutubePage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction({'seconds':2}))
+ action_runner.Wait(2)
class BlogSpotPage(ToughPinchZoomCasesPage):
@@ -152,11 +141,7 @@ class BlogSpotPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'text': 'accessibility',
- 'condition': 'element'
- }))
+ action_runner.WaitForElement(text='accessibility')
class FacebookPage(ToughPinchZoomCasesPage):
@@ -171,11 +156,7 @@ class FacebookPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- {
- 'text': 'About',
- 'condition': 'element'
- }))
+ action_runner.WaitForElement(text='About')
class LinkedinPage(ToughPinchZoomCasesPage):
@@ -209,7 +190,7 @@ class TwitterPage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction({'seconds':2}))
+ action_runner.Wait(2)
class ESPNPage(ToughPinchZoomCasesPage):
@@ -243,7 +224,7 @@ class YahooGamePage(ToughPinchZoomCasesPage):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction({'seconds':2}))
+ action_runner.Wait(2)
class YahooAnswersPage(ToughPinchZoomCasesPage):
« no previous file with comments | « tools/perf/page_sets/tough_energy_cases.py ('k') | tools/perf/page_sets/tough_scheduling_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698