Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/perf/page_sets/polymer.py

Issue 321563003: Add Wait* API to ActionRunner to wrap over WaitAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/plus_alt_posts_photos.py ('k') | tools/perf/page_sets/service_worker.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/polymer.py
diff --git a/tools/perf/page_sets/polymer.py b/tools/perf/page_sets/polymer.py
index 84b57d330f67a1f38eba9ea375a8b278137b5862..5ec680805aa13300176c338adf66d33bdaaecaed 100644
--- a/tools/perf/page_sets/polymer.py
+++ b/tools/perf/page_sets/polymer.py
@@ -21,8 +21,8 @@ class PolymerPage(page_module.Page):
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
- action_runner.RunAction(WaitAction(
- { 'javascript': "window.__polymer_ready" }))
+ action_runner.WaitForJavaScriptCondition(
+ 'window.__polymer_ready')
class PolymerCalculatorPage(PolymerPage):
@@ -94,10 +94,7 @@ class PolymerShadowPage(PolymerPage):
def RunSmoothness(self, action_runner):
action_runner.ExecuteJavaScript(
"document.getElementById('fab').scrollIntoView()")
- action_runner.RunAction(WaitAction(
- {
- 'seconds': 5
- }))
+ action_runner.Wait(5)
self.AnimateShadow(action_runner, 'card')
self.AnimateShadow(action_runner, 'fab')
@@ -105,10 +102,7 @@ class PolymerShadowPage(PolymerPage):
for i in range(1, 6):
action_runner.ExecuteJavaScript(
'document.getElementById("{0}").z = {1}'.format(eid, i))
- action_runner.RunAction(WaitAction(
- {
- 'seconds': 1
- }))
+ action_runner.Wait(1)
class PolymerPageSet(page_set_module.PageSet):
« no previous file with comments | « tools/perf/page_sets/plus_alt_posts_photos.py ('k') | tools/perf/page_sets/service_worker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698